fix: persist sparsekernel browser origins

Author: CharGrnmn

crates/sparsekernel-cli/src/lib.rs

@@ -5,11 +5,12 @@ use serde::Deserialize;
 use serde_json::{json, Value};
 use sparsekernel_core::{
     probe_browser_endpoint, probe_sandbox_backends, AppendTranscriptEventInput, ArtifactStore,
-    AuditInput, BrowserBroker, CapabilityCheck, CompleteToolCallInput, CreateToolCallInput,
-    EnqueueTaskInput, GrantCapabilityInput, LedgerToolBroker, ListBrowserObservationsInput,
-    ListBrowserTargetsInput, LocalSandboxBroker, MockBrowserBroker, RecordBrowserObservationInput,
-    RecordBrowserTargetInput, ResourceBudgetUpdateInput, SandboxBroker, SparseKernelDb,
-    SparseKernelPaths, ToolBroker, UpsertSessionInput, SPARSEKERNEL_PROTOCOL_VERSION,
+    AuditInput, BrowserBroker, BrowserContextAcquireInput, CapabilityCheck, CompleteToolCallInput,
+    CreateToolCallInput, EnqueueTaskInput, GrantCapabilityInput, LedgerToolBroker,
+    ListBrowserObservationsInput, ListBrowserTargetsInput, LocalSandboxBroker, MockBrowserBroker,
+    RecordBrowserObservationInput, RecordBrowserTargetInput, ResourceBudgetUpdateInput,
+    SandboxBroker, SparseKernelDb, SparseKernelPaths, ToolBroker, UpsertSessionInput,
+    SPARSEKERNEL_PROTOCOL_VERSION,
 };
 use std::collections::HashMap;
 use std::error::Error;
@@ -317,6 +318,7 @@ struct AcquireBrowserContextRequest {
     trust_zone_id: String,
     max_contexts: Option<i64>,
     cdp_endpoint: Option<String>,
+    allowed_origins: Option<Value>,
 }
 
 #[derive(Debug, Deserialize)]
@@ -1497,12 +1499,15 @@ pub fn handle_api_request_with_daemon_state(
             ApiReply {
                 status_code: 200,
                 body: serde_json::to_value(broker.acquire_context(
-                    input.agent_id.as_deref(),
-                    input.session_id.as_deref(),
-                    input.task_id.as_deref(),
-                    &input.trust_zone_id,
-                    input.max_contexts.unwrap_or(2),
-                    input.cdp_endpoint.as_deref(),
+                    BrowserContextAcquireInput {
+                        agent_id: input.agent_id.as_deref(),
+                        session_id: input.session_id.as_deref(),
+                        task_id: input.task_id.as_deref(),
+                        trust_zone_id: &input.trust_zone_id,
+                        max_contexts: input.max_contexts.unwrap_or(2),
+                        cdp_endpoint: input.cdp_endpoint.as_deref(),
+                        allowed_origins: input.allowed_origins.as_ref(),
+                    },
                 )?)?,
             }
         }
@@ -2371,10 +2376,12 @@ mod tests {
                 "trust_zone_id": "public_web",
                 "max_contexts": 1,
                 "cdp_endpoint": "http://127.0.0.1:9222",
+                "allowed_origins": ["https://example.com"],
             }),
         );
         let context_id = context["id"].as_str().unwrap().to_string();
         assert_eq!(context["status"], "active");
+        assert_eq!(context["allowed_origins"][0], "https://example.com");
 
         let observed = json_call(
             &mut db,
@@ -2438,6 +2445,7 @@ mod tests {
             .unwrap()
             .body;
         assert_eq!(contexts.as_array().unwrap().len(), 1);
+        assert_eq!(contexts[0]["allowed_origins"][0], "https://example.com");
 
         let pools = handle_api_request(&mut db, "GET", "/browser/pools", &[])
             .unwrap()

crates/sparsekernel-core/src/lib.rs

@@ -397,6 +397,7 @@ pub struct BrowserContextRecord {
     pub session_id: Option<String>,
     pub task_id: Option<String>,
     pub profile_mode: String,
+    pub allowed_origins: Option<Value>,
     pub status: String,
     pub created_at: String,
 }
@@ -1736,7 +1737,7 @@ impl SparseKernelDb {
 
     pub fn list_browser_contexts(&self, limit: i64) -> Result<Vec<BrowserContextRecord>> {
         let mut stmt = self.conn.prepare(
-            "SELECT id, pool_id, agent_id, session_id, task_id, profile_mode, status, created_at
+            "SELECT id, pool_id, agent_id, session_id, task_id, profile_mode, allowed_origins_json, status, created_at
              FROM browser_contexts ORDER BY created_at DESC LIMIT ?",
         )?;
         let rows = stmt.query_map(params![limit.max(0)], browser_context_from_row)?;
@@ -2108,8 +2109,9 @@ fn browser_context_from_row(row: &rusqlite::Row<'_>) -> rusqlite::Result<Browser
         session_id: row.get(3)?,
         task_id: row.get(4)?,
         profile_mode: row.get(5)?,
-        status: row.get(6)?,
-        created_at: row.get(7)?,
+        allowed_origins: parse_json(row.get(6)?),
+        status: row.get(7)?,
+        created_at: row.get(8)?,
     })
 }
 
@@ -2715,30 +2717,39 @@ impl ToolBroker for LedgerToolBroker<'_> {
 pub trait BrowserBroker {
     fn acquire_context(
         &self,
-        agent_id: Option<&str>,
-        session_id: Option<&str>,
-        task_id: Option<&str>,
-        trust_zone_id: &str,
-        max_contexts: i64,
-        cdp_endpoint: Option<&str>,
+        input: BrowserContextAcquireInput<'_>,
     ) -> Result<BrowserContextRecord>;
     fn release_context(&self, context_id: &str) -> Result<bool>;
 }
 
+pub struct BrowserContextAcquireInput<'a> {
+    pub agent_id: Option<&'a str>,
+    pub session_id: Option<&'a str>,
+    pub task_id: Option<&'a str>,
+    pub trust_zone_id: &'a str,
+    pub max_contexts: i64,
+    pub cdp_endpoint: Option<&'a str>,
+    pub allowed_origins: Option<&'a Value>,
+}
+
 pub struct MockBrowserBroker<'a> {
     pub db: &'a SparseKernelDb,
 }
 
 impl BrowserBroker for MockBrowserBroker<'_> {
     fn acquire_context(
         &self,
-        agent_id: Option<&str>,
-        session_id: Option<&str>,
-        task_id: Option<&str>,
-        trust_zone_id: &str,
-        max_contexts: i64,
-        cdp_endpoint: Option<&str>,
+        input: BrowserContextAcquireInput<'_>,
     ) -> Result<BrowserContextRecord> {
+        let BrowserContextAcquireInput {
+            agent_id,
+            session_id,
+            task_id,
+            trust_zone_id,
+            max_contexts,
+            cdp_endpoint,
+            allowed_origins,
+        } = input;
         if let Some(endpoint) = cdp_endpoint {
             validate_browser_cdp_endpoint(endpoint)?;
         }
@@ -2815,9 +2826,17 @@ impl BrowserBroker for MockBrowserBroker<'_> {
         }
         let context_id = format!("browser_ctx_{}", Uuid::new_v4());
         self.db.conn.execute(
-            "INSERT INTO browser_contexts(id, pool_id, agent_id, session_id, task_id, profile_mode, status, created_at)
-             VALUES(?, ?, ?, ?, ?, 'ephemeral', 'active', ?)",
-            params![context_id, pool_id, agent_id, session_id, task_id, now],
+            "INSERT INTO browser_contexts(id, pool_id, agent_id, session_id, task_id, profile_mode, allowed_origins_json, status, created_at)
+             VALUES(?, ?, ?, ?, ?, 'ephemeral', ?, 'active', ?)",
+            params![
+                context_id,
+                pool_id,
+                agent_id,
+                session_id,
+                task_id,
+                json_text(allowed_origins),
+                now
+            ],
         )?;
         self.db.conn.execute(
             "INSERT INTO resource_leases(id, resource_type, resource_id, owner_task_id, owner_agent_id, trust_zone_id, status, created_at, updated_at)
@@ -2843,6 +2862,7 @@ impl BrowserBroker for MockBrowserBroker<'_> {
             session_id: session_id.map(str::to_string),
             task_id: task_id.map(str::to_string),
             profile_mode: "ephemeral".to_string(),
+            allowed_origins: allowed_origins.cloned(),
             status: "active".to_string(),
             created_at: now,
         })
@@ -3526,10 +3546,26 @@ mod tests {
         .unwrap();
         let broker = MockBrowserBroker { db: &db };
         assert!(broker
-            .acquire_context(Some("agent-a"), None, None, "public_web", 10, None)
+            .acquire_context(BrowserContextAcquireInput {
+                agent_id: Some("agent-a"),
+                session_id: None,
+                task_id: None,
+                trust_zone_id: "public_web",
+                max_contexts: 10,
+                cdp_endpoint: None,
+                allowed_origins: None,
+            })
             .is_ok());
         let denied = broker
-            .acquire_context(Some("agent-a"), None, None, "authenticated_web", 10, None)
+            .acquire_context(BrowserContextAcquireInput {
+                agent_id: Some("agent-a"),
+                session_id: None,
+                task_id: None,
+                trust_zone_id: "authenticated_web",
+                max_contexts: 10,
+                cdp_endpoint: None,
+                allowed_origins: None,
+            })
             .unwrap_err()
             .to_string();
         assert!(denied.contains("browser context budget exhausted"));
@@ -3768,14 +3804,15 @@ mod tests {
         .unwrap();
         let browser = MockBrowserBroker { db: &db };
         let context = browser
-            .acquire_context(
-                Some("main"),
-                None,
-                None,
-                "public_web",
-                1,
-                Some("http://127.0.0.1:9222"),
-            )
+            .acquire_context(BrowserContextAcquireInput {
+                agent_id: Some("main"),
+                session_id: None,
+                task_id: None,
+                trust_zone_id: "public_web",
+                max_contexts: 1,
+                cdp_endpoint: Some("http://127.0.0.1:9222"),
+                allowed_origins: None,
+            })
             .unwrap();
         let pools = db.list_browser_pools().unwrap();
         assert_eq!(pools[0].browser_kind, "cdp");
@@ -3784,7 +3821,15 @@ mod tests {
             Some("http://127.0.0.1:9222")
         );
         assert!(browser
-            .acquire_context(Some("main"), None, None, "public_web", 1, None)
+            .acquire_context(BrowserContextAcquireInput {
+                agent_id: Some("main"),
+                session_id: None,
+                task_id: None,
+                trust_zone_id: "public_web",
+                max_contexts: 1,
+                cdp_endpoint: None,
+                allowed_origins: None,
+            })
             .is_err());
         assert!(browser.release_context(&context.id).unwrap());
         let sandbox = LocalSandboxBroker { db: &db };

docs/reference/test.md

@@ -14,7 +14,7 @@ title: "Tests"
 - `OPENCLAW_TEST_CHANGED_BROAD=1 pnpm test:changed`: explicit broad changed test run. Use it when a test harness/config/package edit should fall back to Vitest's broader changed-test behavior.
 - `pnpm changed:lanes`: shows the architectural lanes triggered by the diff against `origin/main`.
 - `pnpm check:changed`: runs the smart changed check gate for the diff against `origin/main`. It runs typecheck, lint, and guard commands for the affected architectural lanes, but does not run Vitest tests. Use `pnpm test:changed` or explicit `pnpm test <target>` for test proof.
-- Rust workspace changes route through active-toolchain `cargo fmt --all --check`, `cargo package -p sparsekernel-core --locked`, `cargo clippy --workspace --all-targets --locked -- -D warnings`, and `cargo test --workspace --locked` locally; CI runs the same Rust lane with Rust 1.80.0 to enforce the workspace MSRV.
+- Rust workspace changes route through active-toolchain `cargo fmt --all --check`, `cargo package -p sparsekernel-core --locked --allow-dirty`, `cargo clippy --workspace --all-targets --locked -- -D warnings`, and `cargo test --workspace --locked` locally; CI runs the clean package equivalent with Rust 1.80.0 to enforce the workspace MSRV.
 - `pnpm test`: routes explicit file/directory targets through scoped Vitest lanes. Untargeted runs use fixed shard groups and expand to leaf configs for local parallel execution; the extension group always expands to the per-extension shard configs instead of one giant root-project process.
 - Test wrapper runs end with a short `[test] passed|failed|skipped ... in ...` summary. Vitest's own duration line stays the per-shard detail.
 - Full, extension, and include-pattern shard runs update local timing data in `.artifacts/vitest-shard-timings.json`; later whole-config runs use those timings to balance slow and fast shards. Include-pattern CI shards append the shard name to the timing key, which keeps filtered shard timings visible without replacing whole-config timing data. Set `OPENCLAW_TEST_PROJECTS_TIMINGS=0` to ignore the local timing artifact.

scripts/check-changed.mjs

@@ -126,7 +126,13 @@ export function createChangedCheckPlan(result, options = {}) {
   }
   if (lanes.rust) {
     addCommand("rust format", "cargo", ["fmt", "--all", "--check"]);
-    addCommand("rust package", "cargo", ["package", "-p", "sparsekernel-core", "--locked"]);
+    addCommand("rust package", "cargo", [
+      "package",
+      "-p",
+      "sparsekernel-core",
+      "--locked",
+      "--allow-dirty",
+    ]);
     addCommand("rust lint", "cargo", [
       "clippy",
       "--workspace",

test/scripts/changed-lanes.test.ts

@@ -256,7 +256,7 @@ describe("scripts/changed-lanes", () => {
     });
     expect(plan.commands.find((command) => command.name === "rust package")).toMatchObject({
       bin: "cargo",
-      args: ["package", "-p", "sparsekernel-core", "--locked"],
+      args: ["package", "-p", "sparsekernel-core", "--locked", "--allow-dirty"],
     });
     expect(plan.commands.find((command) => command.name === "rust tests")).toMatchObject({
       bin: "cargo",