|
| 1 | +package config |
| 2 | + |
| 3 | +import "testing" |
| 4 | + |
| 5 | +// Ports tests/test_model_tiers.py — the per-tier model env vars |
| 6 | +// (SWE_MODEL_LOW / _MED / _HIGH). |
| 7 | +// |
| 8 | +// Validation contract: |
| 9 | +// - No tier envs set → resolution is unchanged for every runtime. |
| 10 | +// - A tier var applies to exactly the roles in its tier (see RoleToTier). |
| 11 | +// - Tier vars beat the SWE_DEFAULT_MODEL → AI_MODEL → HARNESS_MODEL cascade, |
| 12 | +// and lose to caller config (models["default"], models["<role>"]). |
| 13 | +// - SWE_MODEL_HIGH also wins the DefaultPlanningModel cascade (the planning |
| 14 | +// reasoners are high-tier roles). |
| 15 | + |
| 16 | +// highTierFields ports _HIGH_FIELDS. |
| 17 | +var highTierFields = map[string]bool{ |
| 18 | + "pm_model": true, |
| 19 | + "architect_model": true, |
| 20 | + "tech_lead_model": true, |
| 21 | + "replan_model": true, |
| 22 | +} |
| 23 | + |
| 24 | +// openCodeBaseModel ports _OPEN_CODE_BASE. |
| 25 | +const openCodeBaseModel = "openrouter/minimax/minimax-m2.5" |
| 26 | + |
| 27 | +// TestModelTiers_NoTierEnvsUnchanged ports TestNoTierEnvsUnchanged: no tier |
| 28 | +// envs set → resolution unchanged for all runtimes. |
| 29 | +func TestModelTiers_NoTierEnvsUnchanged(t *testing.T) { |
| 30 | + tests := []struct { |
| 31 | + name string |
| 32 | + runtime string |
| 33 | + env map[string]string |
| 34 | + want func(field string) string |
| 35 | + }{ |
| 36 | + {"claude_code base defaults", "claude_code", nil, func(field string) string { |
| 37 | + if field == "qa_synthesizer_model" { |
| 38 | + return "haiku" |
| 39 | + } |
| 40 | + return "sonnet" |
| 41 | + }}, |
| 42 | + {"open_code base defaults", "open_code", nil, |
| 43 | + func(string) string { return openCodeBaseModel }}, |
| 44 | + {"codex base defaults", "codex", map[string]string{"SWE_CODEX_AUTH_MODE": "api_key"}, |
| 45 | + func(string) string { return "gpt-5.3-codex" }}, |
| 46 | + } |
| 47 | + for _, tc := range tests { |
| 48 | + t.Run(tc.name, func(t *testing.T) { |
| 49 | + clearProviderEnv(t) |
| 50 | + for k, v := range tc.env { |
| 51 | + t.Setenv(k, v) |
| 52 | + } |
| 53 | + got := mustResolve(t, tc.runtime, nil) |
| 54 | + for _, field := range AllModelFields { |
| 55 | + if want := tc.want(field); got[field] != want { |
| 56 | + t.Errorf("field %s = %q, want %q", field, got[field], want) |
| 57 | + } |
| 58 | + } |
| 59 | + }) |
| 60 | + } |
| 61 | +} |
| 62 | + |
| 63 | +// TestModelTiers_TierEnvApplication ports TestTierEnvApplication: a tier var |
| 64 | +// applies to exactly the roles in its tier. |
| 65 | +func TestModelTiers_TierEnvApplication(t *testing.T) { |
| 66 | + t.Run("high only changes exactly the high-tier fields", func(t *testing.T) { |
| 67 | + clearProviderEnv(t) |
| 68 | + t.Setenv("SWE_MODEL_HIGH", "openrouter/z-ai/glm-5.2") |
| 69 | + got := mustResolve(t, "open_code", nil) |
| 70 | + for _, field := range AllModelFields { |
| 71 | + want := openCodeBaseModel |
| 72 | + if highTierFields[field] { |
| 73 | + want = "openrouter/z-ai/glm-5.2" |
| 74 | + } |
| 75 | + if got[field] != want { |
| 76 | + t.Errorf("field %s = %q, want %q", field, got[field], want) |
| 77 | + } |
| 78 | + } |
| 79 | + }) |
| 80 | + |
| 81 | + t.Run("all three tiers resolve every field by role tier", func(t *testing.T) { |
| 82 | + clearProviderEnv(t) |
| 83 | + tierModels := map[string]string{ |
| 84 | + "high": "openrouter/z-ai/glm-5.2", |
| 85 | + "med": "openrouter/deepseek/deepseek-v4-pro", |
| 86 | + "low": "openrouter/deepseek/deepseek-v4-flash", |
| 87 | + } |
| 88 | + for tier, model := range tierModels { |
| 89 | + t.Setenv(tierModelEnvVars[tier], model) |
| 90 | + } |
| 91 | + got := mustResolve(t, "open_code", nil) |
| 92 | + for role, field := range RoleToModelField { |
| 93 | + if want := tierModels[RoleToTier[role]]; got[field] != want { |
| 94 | + t.Errorf("role %s (%s) = %q, want %q", role, field, got[field], want) |
| 95 | + } |
| 96 | + } |
| 97 | + }) |
| 98 | + |
| 99 | + t.Run("empty tier value treated as unset", func(t *testing.T) { |
| 100 | + clearProviderEnv(t) |
| 101 | + t.Setenv("SWE_MODEL_HIGH", " ") |
| 102 | + got := mustResolve(t, "open_code", nil) |
| 103 | + for _, field := range AllModelFields { |
| 104 | + if got[field] != openCodeBaseModel { |
| 105 | + t.Errorf("field %s = %q, want %q", field, got[field], openCodeBaseModel) |
| 106 | + } |
| 107 | + } |
| 108 | + }) |
| 109 | +} |
| 110 | + |
| 111 | +// TestModelTiers_Precedence ports TestTierPrecedence: tier vars beat the |
| 112 | +// default-model env cascade and lose to caller config. |
| 113 | +func TestModelTiers_Precedence(t *testing.T) { |
| 114 | + t.Run("models.default beats all tier vars", func(t *testing.T) { |
| 115 | + clearProviderEnv(t) |
| 116 | + t.Setenv("SWE_MODEL_HIGH", "tier-high") |
| 117 | + t.Setenv("SWE_MODEL_MED", "tier-med") |
| 118 | + t.Setenv("SWE_MODEL_LOW", "tier-low") |
| 119 | + got := mustResolve(t, "open_code", map[string]string{"default": "caller-default"}) |
| 120 | + for _, field := range AllModelFields { |
| 121 | + if got[field] != "caller-default" { |
| 122 | + t.Errorf("field %s = %q, want caller-default", field, got[field]) |
| 123 | + } |
| 124 | + } |
| 125 | + }) |
| 126 | + |
| 127 | + t.Run("models.<role> beats everything for that role only", func(t *testing.T) { |
| 128 | + clearProviderEnv(t) |
| 129 | + t.Setenv("SWE_MODEL_MED", "tier-med") |
| 130 | + got := mustResolve(t, "open_code", map[string]string{"coder": "caller-coder"}) |
| 131 | + if got["coder_model"] != "caller-coder" { |
| 132 | + t.Errorf("coder_model = %q, want caller-coder", got["coder_model"]) |
| 133 | + } |
| 134 | + // Other med-tier roles still pick up the tier env value. |
| 135 | + if got["qa_model"] != "tier-med" { |
| 136 | + t.Errorf("qa_model = %q, want tier-med", got["qa_model"]) |
| 137 | + } |
| 138 | + }) |
| 139 | + |
| 140 | + t.Run("tier var beats default env cascade for its roles", func(t *testing.T) { |
| 141 | + clearProviderEnv(t) |
| 142 | + t.Setenv("SWE_DEFAULT_MODEL", "env-default") |
| 143 | + t.Setenv("AI_MODEL", "env-ai-model") |
| 144 | + t.Setenv("SWE_MODEL_HIGH", "tier-high") |
| 145 | + got := mustResolve(t, "open_code", nil) |
| 146 | + for _, field := range AllModelFields { |
| 147 | + // Unset tiers still get the cascade winner (SWE_DEFAULT_MODEL). |
| 148 | + want := "env-default" |
| 149 | + if highTierFields[field] { |
| 150 | + want = "tier-high" |
| 151 | + } |
| 152 | + if got[field] != want { |
| 153 | + t.Errorf("field %s = %q, want %q", field, got[field], want) |
| 154 | + } |
| 155 | + } |
| 156 | + }) |
| 157 | +} |
| 158 | + |
| 159 | +// TestDefaultPlanningModel_HighTier ports TestDefaultPlanningModelHighTier: |
| 160 | +// SWE_MODEL_HIGH wins the planning-model cascade; without it the prior |
| 161 | +// behavior is unchanged. |
| 162 | +func TestDefaultPlanningModel_HighTier(t *testing.T) { |
| 163 | + tests := []struct { |
| 164 | + name string |
| 165 | + env map[string]string |
| 166 | + want string |
| 167 | + }{ |
| 168 | + {"high tier var wins over default-model env", |
| 169 | + map[string]string{"SWE_DEFAULT_MODEL": "env-default", "SWE_MODEL_HIGH": "tier-high"}, "tier-high"}, |
| 170 | + {"unset high tier falls back to env cascade", |
| 171 | + map[string]string{"SWE_DEFAULT_MODEL": "env-default"}, "env-default"}, |
| 172 | + {"whitespace high tier treated as unset", |
| 173 | + map[string]string{"SWE_MODEL_HIGH": " "}, "sonnet"}, |
| 174 | + {"no env at all defaults to sonnet", nil, "sonnet"}, |
| 175 | + } |
| 176 | + for _, tc := range tests { |
| 177 | + t.Run(tc.name, func(t *testing.T) { |
| 178 | + clearProviderEnv(t) |
| 179 | + for k, v := range tc.env { |
| 180 | + t.Setenv(k, v) |
| 181 | + } |
| 182 | + if got := DefaultPlanningModel(); got != tc.want { |
| 183 | + t.Fatalf("DefaultPlanningModel() = %q, want %q", got, tc.want) |
| 184 | + } |
| 185 | + }) |
| 186 | + } |
| 187 | +} |
| 188 | + |
| 189 | +// TestModelTiers_MappingCompleteness ports TestTierMappingCompleteness: every |
| 190 | +// role has a tier, and every tier is a known tier. |
| 191 | +func TestModelTiers_MappingCompleteness(t *testing.T) { |
| 192 | + t.Run("every role has a tier", func(t *testing.T) { |
| 193 | + for role := range RoleToModelField { |
| 194 | + if _, ok := RoleToTier[role]; !ok { |
| 195 | + t.Errorf("role %q missing from RoleToTier", role) |
| 196 | + } |
| 197 | + } |
| 198 | + for role := range RoleToTier { |
| 199 | + if _, ok := RoleToModelField[role]; !ok { |
| 200 | + t.Errorf("RoleToTier has unknown role %q", role) |
| 201 | + } |
| 202 | + } |
| 203 | + }) |
| 204 | + |
| 205 | + t.Run("every tier value is known", func(t *testing.T) { |
| 206 | + known := make(map[string]bool, len(modelTiers)) |
| 207 | + for _, tier := range modelTiers { |
| 208 | + known[tier] = true |
| 209 | + } |
| 210 | + for role, tier := range RoleToTier { |
| 211 | + if !known[tier] { |
| 212 | + t.Errorf("role %q has unknown tier %q", role, tier) |
| 213 | + } |
| 214 | + } |
| 215 | + if len(tierModelEnvVars) != len(modelTiers) { |
| 216 | + t.Errorf("tierModelEnvVars has %d tiers, want %d", len(tierModelEnvVars), len(modelTiers)) |
| 217 | + } |
| 218 | + for _, tier := range modelTiers { |
| 219 | + if _, ok := tierModelEnvVars[tier]; !ok { |
| 220 | + t.Errorf("tier %q missing from tierModelEnvVars", tier) |
| 221 | + } |
| 222 | + } |
| 223 | + }) |
| 224 | +} |
0 commit comments