AG-37249 Improve linter to disallow array destructuring in source code.

Squashed commit of the following:

commit 24d396a
Author: jellizaveta <[email protected]>
Date:   Wed Nov 27 13:50:17 2024 +0300

    leave destructuring in tests

commit 0f1dbc4
Author: jellizaveta <[email protected]>
Date:   Tue Nov 26 20:32:08 2024 +0300

    AG-37249 Improve linter to disallow array destructuring in source code.

Author: jellizaveta

.eslintrc.js

@@ -129,5 +129,22 @@ module.exports = {
                 ],
             },
         },
+        // Array destructuring is not allowed according to the
+        // ReferenceError: _slicedToArray is not defined
+        {
+            files: ['src/**/*.{js,ts}'],
+            rules: {
+                'prefer-destructuring': [
+                    'error',
+                    {
+                        array: false,
+                    },
+                ],
+                'no-restricted-syntax': [
+                    'error',
+                    'ArrayPattern',
+                ],
+            },
+        },
     ],
 };

src/scriptlets/trusted-click-element.ts

@@ -328,7 +328,9 @@ export function trustedClickElement(
 
     if (reload) {
         // split reload option by colon
-        const [reloadMarker, reloadValue] = reload.split(COLON);
+        const reloadSplit = reload.split(COLON);
+        const reloadMarker = reloadSplit[0];
+        const reloadValue = reloadSplit[1];
 
         if (reloadMarker !== RELOAD_ON_FINAL_CLICK_MARKER) {
             logMessage(source, `Passed reload option '${reload}' is invalid`);

src/validators/validators.ts

@@ -316,7 +316,7 @@ export const isValidAdgRedirectRule = (rule: string): boolean => {
         return false;
     }
 
-    const [resource] = resources;
+    const resource = resources[0];
 
     if (!resource.resource) {
         return resource.exceptionRule;