Skip to content

Commit e97a0b5

Browse files
committed
Minor: small refactoring in DotAccess
1 parent c386ad4 commit e97a0b5

File tree

1 file changed

+11
-10
lines changed
  • lkql_jit/language/src/main/java/com/adacore/lkql_jit/nodes/expressions/dot

1 file changed

+11
-10
lines changed

lkql_jit/language/src/main/java/com/adacore/lkql_jit/nodes/expressions/dot/DotAccess.java

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ protected Object onObject(
6868
final LKQLObject receiver,
6969
@CachedLibrary("receiver") DynamicObjectLibrary receiverLibrary) {
7070
// Try to get the built in
71-
Object builtIn = this.tryBuildIn(receiver);
71+
Object builtIn = this.tryBuiltIn(receiver);
7272
if (builtIn != null) {
7373
return builtIn;
7474
}
@@ -94,7 +94,7 @@ protected Object onNamespace(
9494
final LKQLNamespace receiver,
9595
@CachedLibrary("receiver") DynamicObjectLibrary receiverLibrary) {
9696
// Try to get the built in
97-
Object builtIn = this.tryBuildIn(receiver);
97+
Object builtIn = this.tryBuiltIn(receiver);
9898
if (builtIn != null) {
9999
return builtIn;
100100
}
@@ -149,7 +149,7 @@ protected Object onNodeCached(
149149
@Specialization(replaces = "onNodeCached")
150150
protected Object onNodeUncached(Libadalang.AdaNode receiver) {
151151
// Try the built_in
152-
Object builtIn = this.tryBuildIn(receiver);
152+
Object builtIn = this.tryBuiltIn(receiver);
153153
if (builtIn != null) {
154154
return builtIn;
155155
}
@@ -170,20 +170,21 @@ protected Object onNodeUncached(Libadalang.AdaNode receiver) {
170170
}
171171

172172
/**
173-
* Fallback when the receiver is a generic object.
173+
* Fallback when the receiver is none of the case identified by the specializations.
174174
*
175-
* @param receiver The receiver generic value.
175+
* @param receiver The receiver value.
176176
* @return The execution of the dot access.
177177
*/
178178
@Fallback
179-
protected Object onGeneric(Object receiver) {
180-
// Try to get the built in
181-
Object builtIn = this.tryBuildIn(receiver);
179+
protected Object onOthers(Object receiver) {
180+
181+
// In the fallback case, only built-in methods are candidates. Try to get a built-in.
182+
Object builtIn = this.tryBuiltIn(receiver);
183+
182184
if (builtIn != null) {
183185
return builtIn;
184186
}
185187

186-
// Throw an exception
187188
throw LKQLRuntimeException.wrongMember(
188189
this.member.getName(), LKQLTypesHelper.fromJava(receiver), this.member);
189190
}
@@ -196,7 +197,7 @@ protected Object onGeneric(Object receiver) {
196197
* @param receiver The receiver object.
197198
* @return The built-in result, null if the built-in method doesn't exist.
198199
*/
199-
protected Object tryBuildIn(Object receiver) {
200+
protected Object tryBuiltIn(Object receiver) {
200201
// Get the built in
201202
BuiltInFunctionValue builtIn = this.getBuiltIn(receiver);
202203
if (builtIn != null) {

0 commit comments

Comments
 (0)