Merge branch 'topic/162' into 'master'

Avoid spurious backtrace when exiting from fatal error.

Closes #162

See merge request eng/libadalang/langkit-query-language!216

Author: Roldak

lkql_jit/lkql_cli/src/main/java/com/adacore/lkql_jit/LKQLChecker.java

@@ -233,6 +233,12 @@ protected int executeScript(Context.Builder contextBuilder) {
             contextBuilder.option("lkql.ignores", this.args.ignores);
         }
 
+        // This is needed to make sure that calls to `exitContext` done from within an isolate
+        // thread (e.g. executing a Java callback from Ada code) directly stop the program instead
+        // of going it the normal way by raising a special exception, as such exceptions won't be
+        // handled by the caller when thrown from inside the isolate thread.
+        contextBuilder.useSystemExit(true);
+
         // Create the context and run the script in it
         try (Context context = contextBuilder.build()) {
             final Source source = Source.newBuilder("lkql", checkerSource, "checker.lkql").build();

lkql_jit/pom.xml

@@ -147,6 +147,16 @@
                     <lineEndings>UNIX</lineEndings>
                 </configuration>
             </plugin>
+
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-compiler-plugin</artifactId>
+                <configuration>
+                    <compilerArgs>
+                        <arg>-implicit:class</arg>
+                    </compilerArgs>
+                </configuration>
+            </plugin>
         </plugins>
     </build>
 

testsuite/drivers/checker_driver.py

@@ -42,13 +42,17 @@ def run(self) -> None:
 
         args += ['-r', self.test_env['rule_name']]
         args += ['--rules-dir', self.test_env['test_dir']]
-        args += ['--keep-going-on-missing-file']
+
+        if self.test_env.get("keep_going_on_missing_file", False):
+            args += ['--keep-going-on-missing-file']
 
         # Run the checker
         if self.perf_mode:
             self.perf_run(args)
         else:
-            self.check_run(args)
+            # Use `catch_error=False` to avoid failing on non-zero status code,
+            # as some tests actually exert erroneous behaviors.
+            self.check_run(args, catch_error=False)
 
     def parse_flagged_lines(self, output: str) -> Flags:
         # Compile the pattern to match a checker output

testsuite/tests/checks/missing_file/prj.gpr renamed to testsuite/tests/checks/missing_file_error/prj.gpr

@@ -0,0 +1 @@
+ERROR: File p.ads not found

testsuite/tests/checks/missing_file/q.ads renamed to testsuite/tests/checks/missing_file_error/q.ads

@@ -0,0 +1,2 @@
+project Prj is
+end Prj;

testsuite/tests/checks/missing_file_error/test.out

@@ -0,0 +1,9 @@
+with P;
+
+package Q is
+   type T is range 1 .. 5;
+
+   subtype U is T;
+
+   X : constant P.T := 2;
+end Q;