Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining tasks after categorization PR #151

Open
3 of 7 tasks
ErikBjare opened this issue Oct 19, 2019 · 2 comments
Open
3 of 7 tasks

Remaining tasks after categorization PR #151

ErikBjare opened this issue Oct 19, 2019 · 2 comments

Comments

@ErikBjare
Copy link
Member

ErikBjare commented Oct 19, 2019

These were the leftover tasks from #145

  • Merge web watcher events into window events in the query? (to allow for classifying by url/domain)
  • Category Tree: If a category has children, but also activity attributed directly to the parent that does not belong to a child, then create a "Other" child containing the activity.
  • Should we have a way to filter on a specific event key? Right now the regexes are applied on every (string) data value. (feat: more categorization and support for select_keys #286)
  • Add a way to show how/which events are (un)categorized
  • Fix summary view to also use Vuex and all the new goodies
  • Improve default categories (Improving the default categories #174)
  • Link to docs and/or regex101, explaining how regular expressions work and how to write good categorization rules.
@ErikBjare ErikBjare changed the title Remaining tasks from categorization PR Remaining tasks after categorization PR Jan 3, 2020
@johan-bjareholt
Copy link
Member

Merge web watcher events into window events in the query? (to allow for classifying by url/domain)

I was trying to prototype this but realized that we need a new transform to accomplish this if we want the durations to be correct. I would propose something like "union_events_split".

The reason why a new transform is needed is because we have to intersect the browser events with the window and afk events to make active time correct, but then we need to merge them back into the window event data. For this to be correct we need to union the event data where they intersect and if they don't perfectly align we need so split the events.

An example which should explain it better:

 * |---------|----------------|
 * | events1 |[a     ][b     ]|
 * | events2 |    [c     ]    |
 * | result  |[a ][ac][bc][b ]|
 * |---------|----------------|

There is the union function in aw-server-python but from the documentation I don't fully understand what it does, it seems similar but slightly different.

@pierre-lehnen-rc
Copy link

Are there still plans to implement the web/window merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants