Reclasified error when a step is run more than once from TableSlicingError to DuplicateWorkflowNameError

Author: JoeJimFlood

activitysim/abm/test/test_pipeline/test_pipeline.py

@@ -13,7 +13,10 @@
 import pytest
 
 from activitysim.core import random, tracing, workflow
-from activitysim.core.exceptions import CheckpointNameNotFoundError, TableSlicingError
+from activitysim.core.exceptions import (
+    CheckpointNameNotFoundError,
+    DuplicateWorkflowNameError,
+)
 
 # set the max households for all tests (this is to limit memory use on travis)
 HOUSEHOLDS_SAMPLE_SIZE = 50
@@ -236,7 +239,7 @@ def test_mini_pipeline_run2():
     regress_mini_auto(state)
 
     # try to run a model already in pipeline
-    with pytest.raises(TableSlicingError) as excinfo:
+    with pytest.raises(DuplicateWorkflowNameError) as excinfo:
         state.run.by_name("auto_ownership_simulate")
     assert "run model 'auto_ownership_simulate' more than once" in str(excinfo.value)
 

activitysim/core/workflow/runner.py

@@ -7,7 +7,7 @@
 from datetime import timedelta
 
 from activitysim.core import tracing
-from activitysim.core.exceptions import DuplicateWorkflowNameError, TableSlicingError
+from activitysim.core.exceptions import DuplicateWorkflowNameError
 from activitysim.core.workflow.accessor import FromState, StateAccessor
 from activitysim.core.workflow.checkpoint import (
     CHECKPOINT_NAME,
@@ -265,7 +265,7 @@ def _pre_run_step(self, model_name: str) -> bool | None:
         if model_name in checkpointed_models:
             if self._obj.settings.duplicate_step_execution == "error":
                 checkpointed_model_bullets = "\n - ".join(checkpointed_models)
-                raise TableSlicingError(
+                raise DuplicateWorkflowNameError(
                     f"Checkpointed Models:\n - {checkpointed_model_bullets}\n"
                     f"Cannot run model '{model_name}' more than once"
                 )