Skip to content

Commit 1c8b5af

Browse files
committed
Increase fastest speed to 13
Added comment and avifenc help text that libaom and rav1e range is 0-10.
1 parent 77e5a8a commit 1c8b5af

File tree

12 files changed

+19
-19
lines changed

12 files changed

+19
-19
lines changed

apps/avifenc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ static void syntaxLong(void)
202202
printf(" -s,--speed S : Encoder speed (%d-%d, slowest-fastest, 'default' or 'd' for codec internal defaults. default speed: 6)\n",
203203
AVIF_SPEED_SLOWEST,
204204
AVIF_SPEED_FASTEST);
205+
printf(" libaom & rav1e range 0-10\n");
205206
printf("\n");
206207
printf("Advanced options:\n");
207208
printf(" -j,--jobs J : Number of jobs (worker threads). Use \"all\" to potentially use as many cores as possible (default: all)\n");

include/avif/avif.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,6 @@ typedef int avifBool;
115115
#define AVIF_SPEED_SLOWEST 0
116116

117117
// Libaom and Rav1e fastest speed setting is 10, while SVT-AV1 fastest profile is 13.
118-
#define AVIF_SPEED_LIBAOM_RAV1E_FASTEST 10
119118
#define AVIF_SPEED_FASTEST 13
120119

121120
// This value is used to indicate that an animated AVIF file has to be repeated infinitely.

tests/gtest/avif16bittest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ TEST_P(SampleTransformTest, Avif16bit) {
4242

4343
EncoderPtr encoder(avifEncoderCreate());
4444
ASSERT_NE(encoder, nullptr);
45-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
45+
encoder->speed = AVIF_SPEED_FASTEST;
4646
encoder->quality = quality;
4747
encoder->qualityAlpha = quality;
4848
encoder->sampleTransformRecipe = recipe;

tests/gtest/avif_fuzztest_helpers.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,7 @@ inline auto ArbitraryAvifEncoder() {
187187
const auto tile_cols_log2 = fuzztest::InRange(0, 6);
188188
// Fuzz only a small range of 'speed' values to avoid slowing down the fuzzer
189189
// too much. The main goal is to fuzz libavif, not the underlying AV1 encoder.
190-
const auto speed = fuzztest::InRange(6, AVIF_SPEED_LIBAOM_RAV1E_FASTEST);
190+
const auto speed = fuzztest::InRange(6, AVIF_SPEED_FASTEST);
191191
return fuzztest::Map(CreateAvifEncoder, codec_choice, max_threads,
192192
min_quantizer, max_quantizer, min_quantizer_alpha,
193193
max_quantizer_alpha, tile_rows_log2, tile_cols_log2,

tests/gtest/avifallocationtest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ void TestEncoding(uint32_t width, uint32_t height, uint32_t depth,
137137
// Try to encode.
138138
EncoderPtr encoder(avifEncoderCreate());
139139
ASSERT_NE(encoder, nullptr);
140-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
140+
encoder->speed = AVIF_SPEED_FASTEST;
141141
testutil::AvifRwData encoded_avif;
142142
ASSERT_EQ(avifEncoderWrite(encoder.get(), image.get(), &encoded_avif),
143143
expected_result);

tests/gtest/avifchangesettingtest.cc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ void TestEncodeDecode(avifCodecChoice codec,
2929
EncoderPtr encoder(avifEncoderCreate());
3030
ASSERT_NE(encoder, nullptr);
3131
encoder->codecChoice = codec;
32-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
32+
encoder->speed = AVIF_SPEED_FASTEST;
3333
encoder->timescale = 1;
3434

3535
for (const auto& option : init_cs_options) {
@@ -134,7 +134,7 @@ TEST(ChangeSettingTest, UnchangeableSetting) {
134134
EncoderPtr encoder(avifEncoderCreate());
135135
ASSERT_NE(encoder, nullptr);
136136
encoder->codecChoice = AVIF_CODEC_CHOICE_AOM;
137-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
137+
encoder->speed = AVIF_SPEED_FASTEST;
138138
encoder->timescale = 1;
139139
ASSERT_EQ(encoder->repetitionCount, AVIF_REPETITION_COUNT_INFINITE);
140140
encoder->minQuantizer = 63;
@@ -178,7 +178,7 @@ TEST(ChangeSettingTest, UnchangeableImageColorRange) {
178178
EncoderPtr encoder(avifEncoderCreate());
179179
ASSERT_NE(encoder, nullptr);
180180
encoder->codecChoice = AVIF_CODEC_CHOICE_AOM;
181-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
181+
encoder->speed = AVIF_SPEED_FASTEST;
182182
encoder->timescale = 1;
183183
ASSERT_EQ(encoder->repetitionCount, AVIF_REPETITION_COUNT_INFINITE);
184184
encoder->quality = AVIF_QUALITY_WORST;
@@ -215,7 +215,7 @@ TEST(ChangeSettingTest, UnchangeableImageChromaSamplePosition) {
215215
EncoderPtr encoder(avifEncoderCreate());
216216
ASSERT_NE(encoder, nullptr);
217217
encoder->codecChoice = AVIF_CODEC_CHOICE_AOM;
218-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
218+
encoder->speed = AVIF_SPEED_FASTEST;
219219
encoder->timescale = 1;
220220
ASSERT_EQ(encoder->repetitionCount, AVIF_REPETITION_COUNT_INFINITE);
221221
encoder->quality = AVIF_QUALITY_WORST;

tests/gtest/avifgridapitest.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ avifResult EncodeDecodeGrid(const std::vector<std::vector<Cell>>& cell_rows,
3737
if (!encoder) {
3838
return AVIF_RESULT_OUT_OF_MEMORY;
3939
}
40-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
40+
encoder->speed = AVIF_SPEED_FASTEST;
4141
encoder->quality = AVIF_QUALITY_LOSSLESS;
4242
encoder->qualityAlpha = AVIF_QUALITY_LOSSLESS;
4343
// cell_image_ptrs exists only to match the libavif API.
@@ -239,7 +239,7 @@ TEST(GridApiTest, SameMatrixCoefficients) {
239239

240240
EncoderPtr encoder(avifEncoderCreate());
241241
ASSERT_NE(encoder, nullptr);
242-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
242+
encoder->speed = AVIF_SPEED_FASTEST;
243243
const avifImage* cell_image_ptrs[2] = {cell_0.get(), cell_1.get()};
244244
ASSERT_EQ(
245245
avifEncoderAddImageGrid(encoder.get(), /*gridCols=*/2, /*gridRows=*/1,
@@ -268,7 +268,7 @@ TEST(GridApiTest, DifferentMatrixCoefficients) {
268268

269269
EncoderPtr encoder(avifEncoderCreate());
270270
ASSERT_NE(encoder, nullptr);
271-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
271+
encoder->speed = AVIF_SPEED_FASTEST;
272272
// Encoding should fail.
273273
const avifImage* cell_image_ptrs[2] = {cell_0.get(), cell_1.get()};
274274
ASSERT_EQ(

tests/gtest/avifincrtest_helpers.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,7 @@ void EncodeAsGrid(const avifImage& image, uint32_t grid_cols,
231231

232232
EncoderPtr encoder(avifEncoderCreate());
233233
ASSERT_NE(encoder, nullptr);
234-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
234+
encoder->speed = AVIF_SPEED_FASTEST;
235235
// Just here to match libavif API.
236236
std::vector<avifImage*> cell_image_ptrs(cell_images.size());
237237
for (size_t i = 0; i < cell_images.size(); ++i) {

tests/gtest/avifiostatstest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ bool GetIoStatsFromEncode(avifIOStats& encoder_io_stats, int quality,
3131

3232
EncoderPtr encoder(avifEncoderCreate());
3333
AVIF_CHECK(encoder != nullptr);
34-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
34+
encoder->speed = AVIF_SPEED_FASTEST;
3535
encoder->quality = quality;
3636
encoder->qualityAlpha = qualityAlpha;
3737
for (int frame = 0; frame < num_frames; ++frame) {

tests/gtest/aviflosslesstest.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ TEST(BasicTest, EncodeDecodeMatrixCoefficients) {
5454
// Encode.
5555
EncoderPtr encoder(avifEncoderCreate());
5656
ASSERT_NE(encoder, nullptr);
57-
encoder->speed = AVIF_SPEED_LIBAOM_RAV1E_FASTEST;
57+
encoder->speed = AVIF_SPEED_FASTEST;
5858
encoder->quality = AVIF_QUALITY_LOSSLESS;
5959
encoder->qualityAlpha = AVIF_QUALITY_LOSSLESS;
6060
testutil::AvifRwData encoded;

0 commit comments

Comments
 (0)