Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation script: run a simple test example at the end #12

Open
MaximeBaudette opened this issue Oct 29, 2015 · 13 comments
Open

Installation script: run a simple test example at the end #12

MaximeBaudette opened this issue Oct 29, 2015 · 13 comments

Comments

@MaximeBaudette
Copy link
Collaborator

Suggestion From Luigi:

  • The set-up script should test the installation by running the simple example I developed for Rafael. It is the text book example of finding the parameters of a 2nd order system. rum_cmd_rafael.m
  • The code should close the Simulink diagram automatically, which with the current code is left opened.

Note @lvanfretti : I'm adding this new issue, to close the previous one, as the solution implemented by @tinrabuzin is working.

@MaximeBaudette
Copy link
Collaborator Author

@lvanfretti
Could you specify the motivation behind having a specific examples run at the end of the installation ?

Since we implemented the test of dependencies in the installation script, I haven't experienced any situation where no error raised in the install process was coupled to a non working Rapid toobox

@lvanfretti
Copy link
Member

@MaximeBaudette what I would like is to make sure that at least the basic example would run without any human intervation.

The most natural thing would be to do it right at installation, but I guess we can have a simple test script for debbuging dependencies and installation. My simple example is ideal for that because it will not put a lot of burden to the machine, and is small enough to set up several tests of the different functionalities and options of the tool.

If someone reports a bug, we can ask to display the output of the installation script or test script.

If you guys can get my basic script working again, and give me an hour or such, I can create some examples / cases of what we want to test.

Finally, it is also a pretty nighfty thing to have the user get something already running when they install rapid so they can start playing... so that was why I want it in the installation, but if you want to make it a separate test script, that is fine with me.

@tinrabuzin
Copy link
Contributor

@lvanfretti If you check out the two pull request you can see how I implemented it now... But, ofc, I'll adapt it to yours and Maxime's decision.

@lvanfretti
Copy link
Member

@tinrabizin you will have to show me, I don't have my M$ Guidos image with me.

@MaximeBaudette
Copy link
Collaborator Author

@tinrabuzin I'll approve the pull request for now.
I still find this solution to be an overkill, as windows are opened for simulink, the graph visualization...
We can think of another to do it in the future, but for now this is what will be implemented

@lvanfretti
Copy link
Member

@MaximeBaudette there are commands to close the simulink model automatically.
It doesn't even need to be opened... but maybe that's inside either the rapid workflow or the FMI workflow.

@tinrabuzin
Copy link
Contributor

@MaximeBaudette @lvanfretti For some reason, the model is closed automatically, at least on my computer. However, I open the model on purpose. To prevent it, you can just remove the two lines starting with open_system.

@MaximeBaudette
Copy link
Collaborator Author

to get me wrong, it gets closed upon completion, but it is open during the iterations

MaximeBaudette added a commit that referenced this issue Feb 23, 2016
Added some try/catch goodies
#12

Second Order example
switched to relative path
Closes #20
#29
@lvanfretti
Copy link
Member

@tinrabuzin which workflow opens the simulink model? Is it RaPId or the FMI?
If it is RaPId, I guess we can use this: link.
If it is the FMI Toolbox, then we have to check if there is an option to set the default to 'don't open the simulink model'.

@tinrabuzin
Copy link
Contributor

@lvanfretti I opened it with my script on purpose wtih open_system. I'll remove this now.

@MaximeBaudette
Copy link
Collaborator Author

now I added some try catch around the example.
it would be off course awesome to add custom message depending on the error code received, but for now we'll be fine wih "something went wrong"

@janlav
Copy link
Contributor

janlav commented Feb 26, 2016

@MaximeBaudette is this issue resolve now?

@MaximeBaudette
Copy link
Collaborator Author

@janlav
Yes and no.
I consider that the test example at the installation is working. I'd prefer if the simulink remained hidden (@tinrabuzin did you fix that or not?).
I intended to leave the issue open so we can discuss whether we need that test or not.

MaximeBaudette added a commit that referenced this issue Mar 1, 2016
- cosmetic changes in main window
- small changes in Check_installed (displays - OK! for each toolbox installed)
- setup example, disabled the opening of the simulink, improves greatly the speed of the install procedure #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants