Skip to content

Commit d6abb5a

Browse files
committed
The author is not a reviewer.
1 parent 3e53f36 commit d6abb5a

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

pydocteur/actions.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ def replace_body_variables(pr: PullRequest, body: str):
4747
new_body = body.replace("@$AUTHOR", "@" + author)
4848
if not reviewers_login:
4949
reviewers_login = get_trad_team_members()
50+
reviewers_login.discard(author)
5051
reviewers = ", @".join(reviewers_login)
5152
new_body = new_body.replace("@$REVIEWERS", "@" + reviewers)
5253
return new_body

pydocteur/github_api.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,9 @@ def get_pull_request(payload):
5757
return gh_repo.get_pull(pr_number)
5858

5959

60-
def get_trad_team_members():
60+
def get_trad_team_members() -> set:
6161
logger.debug("Getting default reviewers from team members")
62-
return [user.login for user in gh.get_organization("afpy").get_team_by_slug("traduction").get_members()]
62+
return {user.login for user in gh.get_organization("afpy").get_team_by_slug("traduction").get_members()}
6363

6464

6565
def has_pr_number(payload) -> bool:

0 commit comments

Comments
 (0)