-
Notifications
You must be signed in to change notification settings - Fork 36
UnicornAFL v3 #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UnicornAFL v3 #43
Conversation
Make unicornafl more Rust-friendly and sync with newest unicorn-engine Rust crate
Fix cmp hook
Fix iter count if we have afl++
Migrate to newest libafl
Allow infinite iteration
Add cmplog
python/unicornafl/__init__.py
Outdated
| cb2, always_validate, persistent_iters, ctypes.cast(idx, ctypes.c_void_p)) | ||
|
|
||
| if isinstance(input_file, str): | ||
| input_file = ctypes.create_string_buffer(input_file.encode('utf-8')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be:
| input_file = ctypes.create_string_buffer(input_file.encode('utf-8')) | |
| input_file = \ | |
| ctypes.cast( | |
| ctypes.create_string_buffer(input_file.encode('utf-8')), | |
| ctypes.c_void_p | |
| ).value |
See same for case below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the changes seem not committed =(.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd argue that a testcase for the uc_afl_fuzz_custom route would be beneficial as well - are there any uncommited changes on the rust part of uc_afl_fuzz_custom? Otherwise I will debug this route a little bit and see if I find anything further
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd argue that a testcase for the
uc_afl_fuzz_customroute would be beneficial as well - are there any uncommited changes on the rust part ofuc_afl_fuzz_custom?
Contributions are highly welcome =).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done for the input_file handling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marvellous :)
It is almost there! I just added maturin support, and the API should be the same with previous versions. The only things we left are: