Skip to content

Conversation

@wtdcode
Copy link
Member

@wtdcode wtdcode commented May 17, 2025

It is almost there! I just added maturin support, and the API should be the same with previous versions. The only things we left are:

  • CI distribution Support
  • C bindings
  • Documents!

cb2, always_validate, persistent_iters, ctypes.cast(idx, ctypes.c_void_p))

if isinstance(input_file, str):
input_file = ctypes.create_string_buffer(input_file.encode('utf-8'))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be:

Suggested change
input_file = ctypes.create_string_buffer(input_file.encode('utf-8'))
input_file = \
ctypes.cast(
ctypes.create_string_buffer(input_file.encode('utf-8')),
ctypes.c_void_p
).value

See same for case below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the changes seem not committed =(.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that a testcase for the uc_afl_fuzz_custom route would be beneficial as well - are there any uncommited changes on the rust part of uc_afl_fuzz_custom? Otherwise I will debug this route a little bit and see if I find anything further

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd argue that a testcase for the uc_afl_fuzz_custom route would be beneficial as well - are there any uncommited changes on the rust part of uc_afl_fuzz_custom?

Contributions are highly welcome =).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done for the input_file handling.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvellous :)

@wtdcode wtdcode merged commit 3809439 into main Jul 18, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants