Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant host argument in MockJedis #27

Open
savinov opened this issue Nov 5, 2014 · 3 comments
Open

Redundant host argument in MockJedis #27

savinov opened this issue Nov 5, 2014 · 3 comments

Comments

@savinov
Copy link

savinov commented Nov 5, 2014

Why MockJedis constructor has host argument?
You can set Jedis host argument to default value, "test" for example and add MockJedis() default constructor.

@idyedov
Copy link
Contributor

idyedov commented Nov 5, 2014

what if someone has "test" defined in their hosts file and calls a method that we don't override?

I think a default value doesn't hurt, but we'd still need a way to override it

@savinov
Copy link
Author

savinov commented Nov 5, 2014

Well, you can set "mock-jedis" as default value, I don't think that anybody has it in /etc/hosts.
If anybody want to set host argument, he can use constructor with argument.

@idyedov
Copy link
Contributor

idyedov commented Nov 5, 2014

I'll see if I can add it sometime this week, or if you were to submit a pull request adding such a constructor, I would happily merge it in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants