Improve uploads between telegram and XMPP #2208
Open
+88
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selfhoster1312
force-pushed
the
upload-url
branch
from
2ace467 to
85a46f9
Compare
selfhoster1312
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously i would only receive empty messages without the attached images across the bridge.
Now we have a limitation which is that most XMPP clients don't support text alongside images (such as image description or in our case uploader identity). So i opted to post a previous message containing just the username and optional comment.
On telegram side the authorship (and optional comment) is added as caption to the uploaded image.
Sorry the code is ugly i'm a bad bad golang developer.