Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditionally declare incompatibility with WooCommerce HPOS #3849

Closed
1 task done
felipeelia opened this issue Feb 28, 2024 · 0 comments · Fixed by #3861
Closed
1 task done

Conditionally declare incompatibility with WooCommerce HPOS #3849

felipeelia opened this issue Feb 28, 2024 · 0 comments · Fixed by #3861
Assignees
Milestone

Comments

@felipeelia
Copy link
Member

felipeelia commented Feb 28, 2024

Is your enhancement related to a problem? Please describe.

Although WooCommerce made the woocommerce_hpos_pre_query filter available, the implementation of #3476 is not a small lift: as queries are built directly as SQL strings, we would need to translate them back to an Elasticsearch query.

In the meantime, we can conditionally declare the plugin incompatible with WooCommerce HPOS, using the snippet provided here.

We will need to account that:

  1. We only run Elasticsearch queries for orders if both the WooCommerce AND the Protected Content features are enabled.
  2. WooCommerce Orders Autosuggest works fine with HPOS (but only in compatibility mode)

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant