-
Notifications
You must be signed in to change notification settings - Fork 110
Open
Labels
good first issueGood for newcomersGood for newcomerskernelsRelated to transaction, batch, or block kernelsRelated to transaction, batch, or block kernels
Description
Similar to #2168, though now we should get rid of the simple pushing procedures in the memory module.
For example, we can remove procedures such as
pub proc get_output_vault_root_ptr
push.OUTPUT_VAULT_ROOT_PTR
end
and use the OUTPUT_VAULT_ROOT_PTR constant directly:
use &kernel::memory::OUTPUT_VAULT_ROOT_PTR
...
# prepare stack for reading output note assets
push.OUTPUT_VAULT_ROOT_PTR dup.2 exec.memory::get_output_note_asset_data_ptr dup
# => [assets_start_ptr, assets_start_ptr, output_vault_root_ptr, num_assets, note_data_ptr,
# output_notes_end_ptr]
...
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomerskernelsRelated to transaction, batch, or block kernelsRelated to transaction, batch, or block kernels