-
Notifications
You must be signed in to change notification settings - Fork 110
Milestone
Description
With #1353 we've migrated to v0.14 version of miden-vm. A few potentially follow ups came out of that PR:
- Add standard component sources to source managers of
TransactionKernel::assemblerand friends if a debug flag is enabled, if that results in better errors.- We should decide what to do with APIs that return
ExecutionError, e.g.TransactionContext::{execute_code, execute_code_with_assembler}orCodeExecutor::{run, execute_program}. In our tests, we can just use miden-miette, but if miden-base users also use these, they should be made aware that they need to do the same in order to get the better errors.
Originally posted by @PhilippGackstatter in #1353
I think this is fine for now, but I would probably change this in the future to make
source_managera field in theTransactionExecutor. The main reasoning here is that source manager is probably set at the time we create aTransactionExecutorand then we should be able to re-use it for different transactions. If, however, we do need to pass a new source manager into this function from time to time, then keeping it as a function argument is fine.
Originally posted by @bobbinth in #1353 (comment)
Additionally, we need to investigate if the source locations are reported correctly.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels