You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, the OperationBuilder runs verification when an operation is built. Unfortunately, because this happens before the op is inserted into a block, it means that various operation traits with associated validation rules, fail automatically. This has caused us to disable/comment out those validation rules temporarily.
After a review, we can fix this situation as follows:
Remove the call to op.verify() in OperationBuilder
Re-enable/uncomment all of the disabled validation rules
Rely on the PassManager to run verification when so configured. This is a built-in feature of the PassManager implementation, so it is not necessary for us to also run verification when constructing ops, especially because it presents the problem described above.
The text was updated successfully, but these errors were encountered:
Currently, the
OperationBuilder
runs verification when an operation is built. Unfortunately, because this happens before the op is inserted into a block, it means that various operation traits with associated validation rules, fail automatically. This has caused us to disable/comment out those validation rules temporarily.After a review, we can fix this situation as follows:
op.verify()
inOperationBuilder
PassManager
to run verification when so configured. This is a built-in feature of thePassManager
implementation, so it is not necessary for us to also run verification when constructing ops, especially because it presents the problem described above.The text was updated successfully, but these errors were encountered: