[BUG] piscine-java > io-args > file-manager: Automated Tests Expecting an Extra Newline

[Pomog]

piscine-java

FileManager

---

my code is

package FileManager;// FileManager.java
import java.io.*;
import java.nio.file.Files;
import java.nio.file.Paths;

public class FileManager {

    public static void createFile(String fileName, String content) throws IOException {
        // Delete the file if it already exists so that we start with a fresh file.
        File file = new File(fileName);
        if (file.exists()) {
            file.delete();
        }
        // Create the file and write the content.
        try (BufferedWriter writer = new BufferedWriter(new FileWriter(file))) {
            writer.write(content);
        }
    }
    
    public static String getContentFile(String fileName) throws IOException {
        // Read all bytes from the file and convert them to a String using the default charset.
        return new String(Files.readAllBytes(Paths.get(fileName)));
    }
    
    public static void deleteFile(String fileName) {
        // Delete the file if it exists.
        File file = new File(fileName);
        if (file.exists()) {
            file.delete();
        }
    }
}

check file

package FileManager;

import java.io.IOException;

public class ExerciseRunner {
    public static void main(String[] args) throws IOException {
        FileManager.createFile("file.txt", "Lorem ipsum");
        System.out.println(FileManager.getContentFile("file.txt"));
        System.out.println(FileManager.getContentFile("file.txt").equals("Lorem ipsum"));
        //FileManager.deleteFile("file.txt");
    }
}

In the terminal I GET

Lorem ipsum
true

Process finished with exit code 0

The ERRORS I GET FROM https://01.kood.tech/intra/johvi/div-01/piscine-java/io-args/file-manager

Error: Already failed code at commit 7e90a0a

Previous output:
/tmp/jansi-2.4.1-94df5496b02f2ba7-libjansi.so.lck (Read-only file system)
[INFO] Scanning for projects...
[INFO] 
[INFO] ------------------------< com.test:Java-Tests >-------------------------
[INFO] Building Java-Tests 1.0-SNAPSHOT
[INFO]   from pom.xml
[INFO] --------------------------------[ jar ]---------------------------------
[INFO] 
[INFO] --- resources:3.3.1:resources (default-resources) @ Java-Tests ---
[WARNING] Using platform encoding (UTF-8 actually) to copy filtered resources, i.e. build is platform dependent!
[INFO] skip non existing resourceDirectory /jail/project/src/main/resources
[INFO] 
[INFO] --- compiler:3.8.1:compile (default-compile) @ Java-Tests ---
[INFO] Changes detected - recompiling the module!
[WARNING] File encoding has not been set, using platform encoding UTF-8, i.e. build is platform dependent!
[INFO] Compiling 3 source files to /jail/project/target/classes
[INFO] 
[INFO] --- exec:3.0.0:java (default-cli) @ Java-Tests ---
╷
├─ JUnit Jupiter ✔
│  └─ FileManagerTest ✔
│     ├─ getContentFile() ✘ The value is not the one in the file
│     ├─ createFile() ■ Previous test failed, aborting subsequent tests.
│     └─ deleteFile() ■ Previous test failed, aborting subsequent tests.
└─ JUnit Vintage ✔

Failures (1):
  JUnit Jupiter:FileManagerTest:getContentFile()
    MethodSource [className = 'FileManagerTest', methodName = 'getContentFile', methodParameterTypes = '']
    => java.lang.AssertionError: The value is not the one in the file
       FileManagerTest.getContentFile(FileManager_test.java:64)
       java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
       java.base/java.lang.reflect.Method.invoke(Method.java:580)
       org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
       org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
       org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
       org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
       org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
       org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
       org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
       [...]

Test run finished after 97 ms
[         3 containers found      ]
[         0 containers skipped    ]
[         3 containers started    ]
[         0 containers aborted    ]
[         3 containers successful ]
[         0 containers failed     ]
[         3 tests found           ]
[         0 tests skipped         ]
[         3 tests started         ]
[         2 tests aborted         ]
[         0 tests successful      ]
[         1 tests failed          ]

Please clarify or correct this Error

[Pomog]

Hello

In my opinion, the automated tests for the piscine-java > io-args > file-manager task are not set up correctly.
I noticed that the following code:

while ((line = reader.readLine()) != null) {
    content.append(line).append("\n");
}

appends an extra new line at the end of the resulting string, which causes the tests to pass. However, I have verified that an alternative approach - one that does not append this extra newline - results in test failures. This suggests that the tests may be expecting an incorrect output.

Could you please let me know where the repository for these tests is located?
I would be happy to submit a fix (or at least try to).

Thank you!